-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python generator script for project templates #669
base: branch-24.03
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some comments
Changes made. Thanks for the comments. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but can we add create-legate-library
to .gitignore
?
27be9a8
to
1403abe
Compare
cmake/tmpl/legate-create-library.in
Outdated
import os | ||
import stat | ||
import sys | ||
from pathlib import Path | ||
from typing import Union | ||
|
||
if len(sys.argv) != 2: | ||
sys.exit("Must give a single argument with the library name") | ||
libname = sys.argv[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import os | |
import stat | |
import sys | |
from pathlib import Path | |
from typing import Union | |
if len(sys.argv) != 2: | |
sys.exit("Must give a single argument with the library name") | |
libname = sys.argv[1] | |
import argparse | |
import os | |
import stat | |
from pathlib import Path | |
from typing import Union | |
parser = argparse.ArgumentParser() | |
parser.add_argument('libname') | |
args = parser.parse_args() | |
libname = args.libname |
I tried doing legate-create-library -h
and that didn't work out well for me.
I tried using this on an editable install (merged with latest branch-23.07), and the following files end up empty:
Is this expected? Note that the $CONDA_PREFIX/bin/legate-create-library
/Users/mpapadakis/legate.core/legate-create-library
|
… into build-template-generator
I tried doing a clean editable installation (after merging with
It appears the templates are under Full build output
|
Okay... moar fixes. Roll again. |
Works for me! |
… into build-template-generator
Migrates some of the project template functionality. Gives the option to generate a template using a python script instead of CMake.